MiniProfiler icon indicating copy to clipboard operation
MiniProfiler copied to clipboard

Published 20 hours ago • verified publisher icon SamSaffron

fix SqlTiming serialization issue which causes SqlTiming.CommandText always be null after MiniProfiler.FromJson()

Open teddymaef opened this issue 11 years ago • 3 comments

fix SqlTiming serialization issue which causes SqlTiming.CommandText always be null after MiniProfiler.FromJson()

teddymaef avatar Sep 29 '13 02:09 teddymaef

this looks like it is in the wrong repo ... should go to https://github.com/MiniProfiler/dotnet

On Sun, Sep 29, 2013 at 12:59 PM, Teddy [email protected] wrote:

fix SqlTiming serialization issue which causes SqlTiming.CommandText

always be null after MiniProfiler.FromJson()

You can merge this Pull Request by running

git pull https://github.com/teddymaef/MiniProfiler feature/fix_sqltiming_json_ser

Or view, comment on, or merge it at:

https://github.com/SamSaffron/MiniProfiler/pull/193 Commit Summary

  • fix SqlTiming serialization issue which cause SqlTiming.CommandText always be null after MiniProfiler.FromJson()

File Changes

  • M StackExchange.Profiling/SqlTiming.cshttps://github.com/SamSaffron/MiniProfiler/pull/193/files#diff-0(2)

Patch Links:

  • https://github.com/SamSaffron/MiniProfiler/pull/193.patch
  • https://github.com/SamSaffron/MiniProfiler/pull/193.diff

SamSaffron avatar Sep 30 '13 05:09 SamSaffron

And that new location is under heavy refactoring right now. I haven't even looked at profiler deserialization from json yet.

dixon avatar Sep 30 '13 05:09 dixon

We have moved this project to https://github.com/MiniProfiler/dotnet - would you please make your changes there? Thank you!

dixon avatar Oct 31 '13 17:10 dixon