SamR1
Add `Gravel` and `Roadbike` sport profile
As the title already communicate there are more sub types of cycling which are widely used. If you are interested in this two new sport profiles then i will try to create a related PR.
@DavidHenryThoreau thanks for the feedback.
Currently i find two naming patterns: Cycling (<Name>) or <Name> (Without the cycling prefix)
"Bike": [
"Cycling (Sport)",
"Cycling (Transport)",
"Cycling (Trekking)",
"Halfbike",
"Mountain Biking",
"Mountain Biking (Electric)",
]
Please vote which of the following name patterns should I follow?
👍 "Gravel Biking", "Road Biking" 💯 "Cycling (Gravel)", "Cycling (Road)"
It would be nice to add short name and a relevant logo, for name I vote :
- Gravel
- Road
Hi,
No problem adding new sports.
However, for me, "Cycling (Sport)" initially includes "Road Biking". But yes, it might be interesting to differentiate between them in order to have dedicated statistics. In this case, "Cycling (Sport)" is more generic (for example, when you go on a bike ride that covers varied terrain (road, trails) and is not linked to a specific type of bike), and "Road Biking" is linked to a route that is exclusively on roads with a road bike.
The difficulty will be to create icons that are sufficiently different and recognizable.
The current icons:
@DavidHenryThoreau I understand your intention to use short names. But i'm not sure if road and gravel is self-explaining enough, if you don't have the context of cycling. Furthermore it introduces a further naming pattern for a cycling activity.
@SamR1 to assign different equipments to my activities was my first idea. But then it isn't easily possible to create statistics for the different bikes. You are true the icons of Roadbiking and Cycling (Sport) should be similar. The icon for Gravelbiking should be more easy. At the end it's a mixture of Cycling(Sport) and Mountain Biking.
Which tool or icon-set do you use to create/choose the icons?
A while ago, I downloaded a set of icons from flaticon.com. I modified some of them with Inkscape.
For "Road Biking", the "Cycling (Sport)" icon could be modified to add drop handlebars. And then it could be reused for "Gravel Biking" by adding rough terrain under the bike.
@SamR1 Does it match your Road Biking icon expectation? (Modified without any inkscape skills :D)
Hi,
Do you need additional information to add the sports? If you prefer, I can make the changes.
Hi,
sorry that i need more time to add these new sport profiles. I'm a Python an Vue newbie and therefore when i'm be free I spend a little bit more time to understand your current implementation and your tool stack. If this topic doesn't have time pressure then i would try it by my own. If you want to add it asap then it make sense that you add these.
Hi,
No problem :)
Here are a few examples of pull requests and the Contributing Guide.
Feel free to ping me if you have any questions :)