Sam Zhou

Results 23 comments of Sam Zhou

We planned next year that we are going to tackle this. More specifically, I will look into the following aspects, in order of priorities: 1. namespaces (only for type definitions)...

Once we make the next release, it will contain https://github.com/facebook/flow/commit/d8bba3cfbb5f68a675dd6b5532f745b050157cc1, which will make it less hostile to use TS type names. Note that this is best effort support (e.g. eslint...

The error is correct, the BUG refers to the fact that the error is misplaced: it's raised as a result of checking file a but raised in file b. Our...

`babel-plugin-syntax-hermes-parser` works by parsing with hermes-parser, and then replacing some of the newer syntax AST nodes that Babel doesn't know into `any` node. It doesn't do stripping of all types...

Reduced example so we can see this more clearly: [link](https://flow.org/try/#1N4Igxg9gdgZglgcxALlAIwIZoKYBsD6uEEAztvhgE6UYCe+JADpdhgCYowa5kA0I2KAFcAtiRQAXSkOz9sADwxgJ+NPTbYuQ3BMnTZA+Y2yU4IwRO4A6SFBIrGVDGM7c+IFkolXpUCWewUEAwhCQgRDH8wEH4hMnwROHlsNnw4KHwwSLAAC3wANyo4LFxscWQuHgMNZmwsiRSAWglaY1cq-hIAa2wJXNpG4Vxcdvdu3v7B0RxKUYMhKDBSqmbWwIq3eagoOrKSKgH0wtMMPznY7d2SfcoBiEZ-aG5G3Ix085AF-ZhsRoRehqUEiNMgSQHlSruBZxJrMcJwMhzAC+-EgGiCLWMAAIACpCRilLEAXixAApSSRkFj7KYoAheFioAB+KnCEQzACUxIAfFi0MRllAuQoGlA2CQyaSrNKqAhKVj0j9KFiAIKUOVcom8xLJNgcgA6UCxWKZqvVJENxqp2BED1oAG5DRollRsFiYAtlHBoFiEFKZeaqXiCdgOVT+RBBY66aT9SAcnA4xzozEQPkTCRvVAghF7CYQEigA) It seems a result of Flow forgetting that the element is optional after inference, and reduces it to `T |...

Hi. I did some investigation on this and make some attempts to fix it, but unfortunately the root of the issue is harder to address than I anticipated. An obvious...

Check again. Go to def and type-at-pos now works, but autocomplete still doesn't quite work, but should be easy to add

Reopen since this one is not solved. The array case is solved.

https://github.com/facebook/flow/commit/ec8a209b46a4635b6a51bdf148a341980fdf3900 would resolve one of the issue. We don't plan to touch the other one, because TS is also being unsound there, and it would be too disruptive.