Sam Armstrong
Sam Armstrong
@sherry30 thanks, that's a good point. I've updated the test to randomly select a data format using hypothesis instead, do you think this looks ok?
@eekamal I'd recommend reading through these two sections of the docs to help you out: https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends.html#ivy-frontends https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html If you have any specific questions, feel free to let me know either...
Thanks for doing that @yunsemr! I think it would actually make more sense to split this into two pull requests - one for the torch frontend and one for the...
@yunsemr You can keep this pull request open, just remove your changes to the paddle backend here. Then create a separate pull request for the paddle fix (and mention this...
@yunsemr You can make a new commit simply changing the paddle backend to what it was before you made any changes. Then push that commit here.
@yunsemr Great! Now you can open a separate pull request with those changes by creating a new branch from your master, and committing your changes there. Then you can push...
@yunsemr No just the changes you made to paddle which you removed here. That way we separate it out into two pull requests.
Looks good, thanks 🙂 I'll review this soon
@ksbharaj please could you add the corresponding frontend test? https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html#ivy-frontend-tests
@ksbharaj we also need a test in ivy/ivy_tests/test_ivy/test_frontends/test_paddle /test_tensor.py, as you've implemented a tensor method here.