DistributedReplays icon indicating copy to clipboard operation
DistributedReplays copied to clipboard

WIP App engine compatibility

Open Sciguymjm opened this issue 5 years ago • 3 comments

Sciguymjm avatar Nov 18 '19 03:11 Sciguymjm

Investigate and specify this except.

https://github.com/SaltieRL/DistributedReplays/blob/a2e6844fe101fc67706474f28595f89cbf8cbf04/backend/database/startup.py#L100-L104


This comment was generated by todo based on a TODO comment in a2e6844fe101fc67706474f28595f89cbf8cbf04 in #407. cc @SaltieRL.

todo[bot] avatar Nov 18 '19 03:11 todo[bot]

change when deploying to google cloud

https://github.com/SaltieRL/DistributedReplays/blob/505af6b554712b8ef30774bf2139037ae73959c8/webapp/src/Requests/Config.ts#L11-L16


This comment was generated by todo based on a TODO comment in 505af6b554712b8ef30774bf2139037ae73959c8 in #407. cc @SaltieRL.

todo[bot] avatar Nov 18 '19 03:11 todo[bot]

Codecov Report

Merging #407 into master will decrease coverage by 2.29%. The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #407     +/-   ##
=========================================
- Coverage   62.25%   59.96%   -2.3%     
=========================================
  Files          90       90             
  Lines        5670     5685     +15     
  Branches      809      813      +4     
=========================================
- Hits         3530     3409    -121     
- Misses       1998     2145    +147     
+ Partials      142      131     -11
Flag Coverage Δ
#integration 40.52% <47.82%> (-10.61%) :arrow_down:
#server 59.68% <52.17%> (-0.87%) :arrow_down:
Impacted Files Coverage Δ
...ueprints/spa_api/service_layers/homepage/recent.py 66.66% <0%> (ø) :arrow_up:
backend/tasks/training_packs/task.py 33.72% <0%> (ø) :arrow_up:
...blueprints/spa_api/service_layers/replay/replay.py 80.95% <100%> (ø) :arrow_up:
...nts/spa_api/service_layers/replay/replay_player.py 56.52% <100%> (-39.14%) :arrow_down:
...nts/spa_api/service_layers/replay/match_history.py 73.68% <50%> (-10.53%) :arrow_down:
backend/database/startup.py 69.41% <58.82%> (+2.35%) :arrow_up:
backend/tasks/utils.py 73.33% <60%> (-8.49%) :arrow_down:
RLBotServer.py 82.35% <62.5%> (-17.65%) :arrow_down:
backend/initial_setup.py 81.32% <75%> (-1.5%) :arrow_down:
...ueprints/spa_api/service_layers/replay/heatmaps.py 11.36% <0%> (-56.82%) :arrow_down:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e1d230...5ef6cea. Read the comment docs.

codecov[bot] avatar Nov 18 '19 03:11 codecov[bot]