salman comments

Results 37 comments of


                                            salman

adding model builders for code-llama2 7b, 13b, and 70b

I updated the docs, and I've just taken out the QLoRA 70B models if it's out of scope out ATM, particularly for this PR. > Is this just due to...

adding model builders for code-llama2 7b, 13b, and 70b

> OK just a few more small comments. Home stretch here! After those are addressed I think this is good to merge Hopefully all done! Thanks for your patience :)

no error when lacking hugging face permissions

It looks like Torchtune defers to `huggingface_hub` to download checkpoints, and handles errors from `huggingface_hub.snapshot_download`. Would it be worth trying the method directly to see what happens? I've included an...

no error when lacking hugging face permissions

@dangbert did you have any luck with this? I found doing a couple things helped when I was having issues downloading models: - checking if `~/.cache/huggingface/` has a cache for...

Update models docs page

Overall this is a huge improvement. I'm not married to the blurbs - we can link to model cards/papers which sufficiently explain the models IMO. I'd love to see the...

Update models docs page

Also, maybe this is obvious to everyone, but it might be a good opportunity to add a little noobsplainer™ about what's up with all our `lora` model and component builders....

Updating generation to use custom_generate_next_token for initial token generation

Thanks so much for the review. I think I kind of get the gist of the original design choice - I'll ping any qs on discord : )