NPSP icon indicating copy to clipboard operation
NPSP copied to clipboard

Published 20 hours ago • verified publisher icon SalesforceFoundation

Preserve secondary address components after comma entered in MailingStreet

Open kevinearldenny opened this issue 4 years ago • 6 comments

Critical Changes

  • Fix a data loss currently occurring for Cicero customers when entering unit numbers in street address for address validation like "3018 Ellwood Ave, 2"

Changes

  • Split out address components after a comma, and add them back in to MailingStreet__c instead of allowing them to get overwritten by the result of match_addr

Issues Closed

#6199

Community Ideas Delivered

Fix an issue encountered by Cicero customers using the NPSP integration where unit numbers are removed when a user enters them as part of Mailing address line 1, i.e. "3018 Ellwood Ave, 2".

Current state

  • API response returns match_addr as "3018 Ellwood Ave"
  • Unit number is stripped from MailingStreet__c, which is updated to be "3018 Ellwood Ave"

Expected

  • API response returns match_addr as "3018 Ellwood Ave"
  • MailingStreet__c is set to "3018 Ellwood Ave, 2"

New Metadata

N/A

Deleted Metadata

N/A

kevinearldenny avatar Jan 21 '21 21:01 kevinearldenny

Thanks for the contribution! Before we can merge this, we need @kevinearldenny to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Jan 21 '21 21:01 salesforce-cla[bot]

Thank you for the contribution @kevinearldenny! I've alerted the NPSP team so that someone can do a review.

W-8777462

coriobriensfdo avatar Jan 21 '21 22:01 coriobriensfdo

Hi @coriobriensfdo - this is still a WIP. Folks from the Cicero team will be reaching out via email with further comms around resolving this issue.

Thanks! Kevin

kevinearldenny avatar Jan 22 '21 16:01 kevinearldenny

Hi @coriobriensfdo - this is still a WIP. Folks from the Cicero team will be reaching out via email with further comms around resolving this issue.

Thanks! Kevin

@kevinearldenny ok I'll let the team know to hold off for now. Regarding the Cicero team, do you mean they're going to be working with you and your team? It might help if you filed an Issue related to this PR so that you can fully explain the issue if it's within the NPSP code.

coriobriensfdo avatar Jan 22 '21 16:01 coriobriensfdo

@coriobriensfdo This should be ready for review now!

cc: @KlaasH

kevinearldenny avatar Jan 25 '21 17:01 kevinearldenny

I'm the product manager for Cicero and I'm wondering if I can get an update on when this PR will be merged into production. We've had more customers running into this bug recently and I'd love to be able to share a fix timeline with them. Thanks! cc @coriobriensfdo @lparrott

stacydein avatar Nov 09 '21 21:11 stacydein