ApexDoc icon indicating copy to clipboard operation
ApexDoc copied to clipboard

Bug fixes & String concatenation performance improvent

Open nginth opened this issue 8 years ago • 4 comments

I ran into a few bugs when using ApexDoc for my org. I mainly fixed a NPE when @group-content points to a file that doesn't exist. I also included some (maybe not necessary) performance improvements by changing some string concatenation to StringBuilder appends.

nginth avatar Dec 07 '16 21:12 nginth

Thanks @nginth! Our development team is actively working on other projects so it may be a while before this can be reviewed and considered. We appreciate your support and patience!

judisohn avatar Dec 08 '16 22:12 judisohn

@nginth I realize this PR is quite old, but I'm attempting to revitalize this project here (I've yet to merge in my first big update, but there's on open PR for it - includes a few new tokens and some other new features), and I noticed this bug and then this PR in my travels. Are you interested in submitting this PR to the new repo once I merge the open PR? If not, I'd be happy to implement the main fix myself and attribute the credit to you. Thanks.

no-stack-dub-sack avatar Feb 15 '19 01:02 no-stack-dub-sack

@no-stack-dub-sack I would be interested in submitting the new PR! I'll subscribe to your open PR and work on getting this one submitted over there when you merge it.

nginth avatar Feb 15 '19 01:02 nginth

@nginth Wow! That was a quick response :smile: There are some pretty significant changes with this first commit, so you likely won't be able to just copy/paste, but some of the sections you edited should be mostly the same. Merging this PR in shortly, see you over there!

no-stack-dub-sack avatar Feb 15 '19 01:02 no-stack-dub-sack