sfcc-ci icon indicating copy to clipboard operation
sfcc-ci copied to clipboard

various SLAS adjustments, added callbackURIs

Open sandragolden opened this issue 2 years ago • 1 comments

Mostly just fixing some minor typos in params, also added callback URIs needed for password resets and passwordless login

cc: @hnestmann

sandragolden avatar Jul 19 '22 23:07 sandragolden

@tobiaslohr This should be ready to merge. I double checked all the commands via the command line as well as via the JS API and they all work without error with the exception of slas:tenant:list and slas:tenant:delete which are restricted to staff only / internal role. I wasn't able to get the JS API to work at all because of auth errors so I added token as the last parameter for all of the API functions.

I don't think there are any breaking-changes here. I switched the order of the params on slas.cli.client.list because that was throwing an error because the params were reversed (issue #265). I added callbackuris to client:add which shouldn't be breaking either. All the other updates were errors (like callbackuris and redirecturis need to always be arrays if null is passed in).

I see this is failing build-and-test in CircleCI but I don't think that's from any changes I've made as the same errors look to be thrown in the master branch. Let me know if I need to take a look at that.

sandragolden avatar Sep 03 '22 07:09 sandragolden

Thanks for your contribution @sandragolden!

tobiaslohr avatar Nov 16 '22 10:11 tobiaslohr