sfcc-ci icon indicating copy to clipboard operation
sfcc-ci copied to clipboard

Published 20 hours ago • verified publisher icon SalesforceCommerceCloud

Test coverage for slas commands

Open tobiaslohr opened this issue 3 years ago • 4 comments

#270 has introduced as breaking change as we've upgraded to a new major version of node-fetch. This caused slas commands to fail, reported in #280. A fix has been provided as part of #285. However, we should add unit tests and CLI functional tests to have some safeguards in place to prevent this from happening again.

tobiaslohr avatar Feb 03 '22 09:02 tobiaslohr

@hnestmann @johnboxall @jbachelet Any thoughts from your side?

tobiaslohr avatar Feb 03 '22 09:02 tobiaslohr

Yes I am fully on board to increase test coverage. Howeber - would unit tests help if dependencies change? Maybe we should think about integration tests with github actions or the like

hnestmann avatar Feb 03 '22 09:02 hnestmann

True for this particular issue. Having a CLI based test would have caught it however.

tobiaslohr avatar Feb 03 '22 10:02 tobiaslohr

I will add unit tests for sure though.

hnestmann avatar Feb 03 '22 10:02 hnestmann