pwa-kit icon indicating copy to clipboard operation
pwa-kit copied to clipboard

Add support for simple products / variation groups

Open hnestmann opened this issue 3 years ago • 7 comments

In order to speed up projects with any type of customer data set, we should add support to the search for different product types, such as simple products and variation groups

Simple products can be found in SFRA electronics category Variations groups e.g. 42416786-3M

https://github.com/SalesforceCommerceCloud/pwa-kit/blob/915bf3e9bceb1fda96279c0b019d26bf108f9470/packages/pwa/app/pages/product-list/index.jsx#L553

hnestmann avatar Nov 16 '21 07:11 hnestmann

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

uip-robot-zz avatar Nov 16 '21 07:11 uip-robot-zz

Hey @hnestmann ! Thank you for bringing this up. The PWA currently doesn't support simple products and variation group and the team is aware of the lack of feature. It's on our roadmap to add support for other product types.

kevinxh avatar Nov 17 '21 20:11 kevinxh

Hey @hnestmann ! Thank you for bringing this up. The PWA currently doesn't support simple products and variation group and the team is aware of the lack of feature. It's on our roadmap to add support for other product types.

Hi @kevinxh, what do you mean exactly by "doesn't support"? I just added "product" to the refine string and it works. I see all Products from the category and iam able to buy them.

searchParams.refine.push('htype=master|product')

dev-niko avatar Jan 05 '22 14:01 dev-niko

@dev-niko by "doesn't support", i mean it's not implemented/tested. You could update the api call to include type product, however, the data structure for those type of products might not be correctly handled on pages like product detail page, you might run into issues. Such scenarios are not tested. You can certainly give it a try.

kevinxh avatar Jan 05 '22 23:01 kevinxh

Here is a PR that demonstrates how you might approach adding support for more product types: https://github.com/SalesforceCommerceCloud/pwa-kit/pull/629

johnboxall avatar Jun 15 '22 23:06 johnboxall

Hello @hnestmann, we are working on this for the first half of 2023!

echessman avatar Nov 30 '22 20:11 echessman

Updating this thread as it's been a while. We still plan on adding support for simple products, but unfortunately have not found the time to address this yet. We hope to do so soon.

bfeister avatar Nov 17 '23 17:11 bfeister