pwa-kit icon indicating copy to clipboard operation
pwa-kit copied to clipboard

@W-14902130 - Allow `ProductId` and `CategoryId` to be passed directly their respective pages

Open bendvc opened this issue 10 months ago • 0 comments

Description

This simple PR makes small change to the <ProductDetail /> and <ProductList /> pages to allow you to pass in the ProductId and CategoryId respectively. We are adding this ability in preparation for work adding the Shopper SEO API to the template.

Types of Changes

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Documentation update
  • [ ] Breaking change (could cause existing functionality to not work as expected)
  • [ ] Other changes (non-breaking changes that does not fit any of the above)

Changes

  • Add 'productId' prop to the ProductDetail page component
    • Add 'categoryId' prop to the ProductList page component

How to Test-Drive This PR

  • (step1)

TODO

  • [ ] Revert changes to routes.jsx
  • [ ] Update tests.

General

  • [ ] Changes are covered by test cases
  • [ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

bendvc avatar Apr 08 '24 21:04 bendvc