Saladoc

Results 21 comments of Saladoc

If the plugin interface provides enough hooks (or access to internal statistics) this could be realized via a plugin. I recommend that actually for prometheus, as it requires another endpoint...

This is something I want to make use of in the near future. @joshuasing are you still working on this? Are you in need of any help or feedback?

With the tools introduced by now, do you consider this fixed?

Go ahead. We usually don't assign issues but coordinate on discord for larger changesets. As far as I'm aware nobody is working on this right now.

You are free to work on as many issues as you like. Bear in mind however that this is a large change that will require a lot of work, review...

I think it was the changed inheritances which might break some binary compatibility. I doubt it's a serious change, but it might require recompilation, so better safe than sorry in...

I'm really not sure if I'm a fan of this. Not because I don't see the value of being able to intercept and monitor the rest requests, but because we're...

There might be some issue here as the deletion endpoint does not support the `X-Audit-Log-Reason` header, therefore the methods accepting an audit log reason are technically not applicable. However we...

I think all of those issues are addressed in the linked PR which I did not have time to review yet due to the scope. @KILLEliteMaste can you clarify?

Test what you can without nitro, write a list of what you tested and what you couldn't test, then find someone who can test the rest.