K1 icon indicating copy to clipboard operation
K1 copied to clipboard

Support Cocoapods integration

Open yllfejziu opened this issue 2 years ago • 4 comments

Current Situation:

  • The K1 library currently supports only Swift Package Manager.
  • CocoaPods is a widely used dependency manager in the iOS community.

Suggested Enhancement:

  • Add support for CocoaPods in the K1 library.

Benefits:

  • This would make K1 more accessible to a broader range of developers.
  • It provides an alternative for those who prefer CocoaPods over SPM.
  • Cocoapods is more friendly for react-native community

yllfejziu avatar Dec 19 '23 08:12 yllfejziu

@yllfejziu Merry Christmas! thanks for opening the issue, sure I can add Cocoapods support, will do it a bit later when Christmas Holidays are over.

Feel free to nudge me in a week or so if I forgot about it! 😅

PRs are always welcome ofc!

Sajjon avatar Dec 25 '23 18:12 Sajjon

@Sajjon

Thanks for the reply! Hope you are enjoying your holidays... 😄

I'm gonna need the SPM support later on when I'll use K1 package in a react-native library, so just wanted to check on the progress of this issue.

Hoping this gets resolved by then (1-2 weeks), if not, I'll definitely open a PR myself.

Thank you 🙌

yllfejziu avatar Jan 03 '24 13:01 yllfejziu

Hey @Sajjon,

I'm trying to support Cocoapods on K1 but I'm stumbling on some issues when referencing source files (headers etc). These issues arise due to the git submodule included which has a lot of exact filenames under different directories. (Check this cocoapods issue: https://github.com/CocoaPods/CocoaPods/issues/8289)

I made some progress on the .podspec file definition, and you can watch it here: https://github.com/yllfejziu/K1/blob/main/K1.podspec

Since you have a deeper understanding of the corresponding files for each module, can you help me out finish this?

Thanks in advance.

yllfejziu avatar Jan 15 '24 10:01 yllfejziu

@yllfejziu thank you for taking trying, did you see this: https://github.com/Boilertalk/secp256k1.swift/blob/master/secp256k1.swift.podspec

perhaps that might help, might worth another try? Otherwise we will have to wait until have find some extra time over....

Sajjon avatar Jan 15 '24 19:01 Sajjon