fudge icon indicating copy to clipboard operation
fudge copied to clipboard

fudge_settings leak across directories

Open celeduc opened this issue 12 years ago • 2 comments

If I specify a value in fudge_settings.yml in a directory that same value will carry over to the next directory unless overridden by a fudge_settings.yml file with that same key.

e.g.:

  each_directory ['meta_one', 'meta_too'] do
    task :torture
  end

meta_one/fudge_settings.yml:

torture:
  threshold: 8
  average: 4

meta_two/fudge_settings.yml:

torture:
  threshold: 8

In this case, the torture task will still apply the average of 4 in meta_two.

celeduc avatar Oct 04 '13 20:10 celeduc

I agree that this is a problem, but when we fix this we may want to consider the question of carrying settings over into sub-directories.

For example, what if I did something like this?

each_directory ['meta/one', 'meta/one/point_1', 'meta/one/point_2', 'meta/too'] do
  task :torture
end

In this case, I would expect any values in meta/one/fudge_settings.yml to carry through to meta/one/point_1 and meta/one/point_2 (unless explicitly overridden in the sub-directory), but not to meta/too.

The case for carrying settings over into sub-directories might be clearer if we rewrite the above as:

each_directory 'meta/**/*' do
  task :torture
end

KevinBrowne avatar Mar 14 '14 09:03 KevinBrowne

Are we saying that it's not possible to override the settings in the Fudgefile declaration? I see carrying through to subdirs as desirable. We might want a flag to say 'recursive: false' or something

loz avatar Mar 27 '14 07:03 loz