carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat(toast): set role to status

Open nuria1110 opened this issue 8 months ago • 0 comments

Proposed behaviour

  • Set role of "status" to Toast component.
  • No axe violation when Toast is rendered.
  • No typo in Select onKeyDown prop description.
  • Links in 'Related Components' section in Alert docs go to component's docs page.

Current behaviour

  • Toast component has no semantic meaning, this causes an axe violation on render: "All page content should be contained by landmarks".
  • Typo in Select onKeyDown prop description.
  • Links in 'Related Components' section in Alert docs go to default story or are broken.

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [ ] Screenshots are included in the PR if useful
  • [ ] All themes are supported if required
  • [ ] Unit tests added or updated if required
  • [ ] Playwright automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [ ] Typescript d.ts file added or updated if required
  • [ ] Related docs have been updated if required

QA

  • [ ] Tested in provided StackBlitz sandbox/Storybook
  • [ ] Add new Playwright test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

nuria1110 avatar Jun 24 '24 16:06 nuria1110