carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Published 20 hours ago • verified publisher icon Sage

fix(filterable-select, multi-select): ensure whitespace is trimmed fom the input when filtering

Open tomdavies73 opened this issue 1 year ago • 1 comments
trafficstars

fix #6446

Proposed behaviour

Ensures that values typed into the input with leading and trailing whitespace, do not affect the filtering of any options in both the FilterableSelect and MultiSelect components

Current behaviour

Currently, any whitespace leading or trailing in the respective components' input results in no options being filtered

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [ ] Screenshots are included in the PR if useful
  • [ ] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [ ] Cypress automation tests added or updated if required
  • [ ] Playwright automation tests added or updated if required
  • [ ] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [ ] Typescript d.ts file added or updated if required
  • [ ] Related docs have been updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

The following CodeSandbox is an example of the broken behaviour. You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

tomdavies73 avatar Jan 24 '24 17:01 tomdavies73

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83e9a44f341e16bc8bef6b776a46fb0b09e3bba1:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR
awesome-rgb-nqnxl5 Issue #6446

codesandbox-ci[bot] avatar Jan 24 '24 17:01 codesandbox-ci[bot]

:tada: This PR is included in version 127.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Mar 28 '24 11:03 carbonci