carbon icon indicating copy to clipboard operation
carbon copied to clipboard

chore: update npm scripts and remove `/scripts` tsconfig

Open Parsium opened this issue 2 years ago • 2 comments

Proposed behaviour

  • Remove generate-proptypes script since it has been refactored to a babel plugin.
  • Remove tsconfig.json from /scripts directory - which has been causing the following typescript error: Cannot write file because it would overwrite input file TS when the file is opened/carbon is built

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Check regressions have not been introduced into the build process

Parsium avatar Sep 30 '22 16:09 Parsium

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c913251a8dc44b560d4eddd053d69dc3513acd34:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

codesandbox-ci[bot] avatar Sep 30 '22 16:09 codesandbox-ci[bot]



Test summary

3125 0 3 0Flakiness 0


Run details

Project carbon
Status Passed
Commit c913251a8d
Started Sep 30, 2022 4:24 PM
Ended Sep 30, 2022 4:30 PM
Duration 05:33 💡
OS Linux Debian - 11.3
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 30 '22 16:09 cypress[bot]

:tada: This PR is included in version 111.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Oct 04 '22 09:10 carbonci