carbon icon indicating copy to clipboard operation
carbon copied to clipboard

test(portrait): add cypress tests

Open divyajindel opened this issue 2 years ago • 2 comments

Proposed behaviour

Refactor for portrait component to use new cypress-component-react framework for testing. I have added test.js and deleted steps.js and feature file.

Current behaviour

Currently we are using the regular cypress approach with BDD.

Checklist

  • [x] Commits follow our style guide
  • [ ] Related issues linked in commit messages if required
  • [ ] Screenshots are included in the PR if useful
  • [ ] All themes are supported if required
  • [ ] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [ ] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [ ] Typescript d.ts file added or updated if required

QA

  • [x] Tested in CodeSandbox/storybook
  • [x] Add new Cypress test coverage if required
  • [x] Carbon implementation matches Design System/designs
  • [x] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

  • [x] Run npx cypress open --component to check if there is newly added test.file
  • [x] Check if the portrait.test.js file passed
  • [x] Compare all tests were moved/refactored from .feature file -> .test.js file
  • [x] Check if all unnecessary files were deleted, including .json file

divyajindel avatar Sep 27 '22 08:09 divyajindel

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 039ba1de4c2f292ea7cde793ce47eaa22c06cec4:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR

codesandbox-ci[bot] avatar Sep 27 '22 08:09 codesandbox-ci[bot]



Test summary

3209 0 3 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 039ba1de4c
Started Oct 10, 2022 9:49 AM
Ended Oct 10, 2022 9:54 AM
Duration 05:26 💡
OS Linux Debian - 11.4
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 27 '22 09:09 cypress[bot]

Happy to approve once @sianford's comments have been addressed too 👍🏼

Parsium avatar Oct 07 '22 10:10 Parsium

:tada: This PR is included in version 111.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Oct 10 '22 13:10 carbonci