carbon icon indicating copy to clipboard operation
carbon copied to clipboard

fix(accordion): update margin-left spacing values to use tokens when buttonHeading is used

Open ljemmo opened this issue 2 years ago • 3 comments

Proposed behaviour

The tertiary button accordion variant was using values instead of token variables. Updated the component to look as expected. See screenshot below: Screenshot 2022-09-09 at 12 13 59

Current behaviour

Currently the tertiary accordion style uses explicit values to acheive spacing (64px and 32px). It looks like this: Screenshot 2022-09-09 at 12 24 43

Checklist

  • [ ] Commits follow our style guide
  • [ ] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [ ] All themes are supported if required
  • [ ] Unit tests added or updated if required
  • [ ] Cypress automation tests added or updated if required
  • [ ] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [ ] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Creating this PR to support the conversation found here: https://sageone.slack.com/archives/C0D6DD3N2/p1662714216349359

Testing instructions

The following CodeSandbox is an example of the broken behaviour. You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

ljemmo avatar Sep 09 '22 11:09 ljemmo

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5f76cb0c2c95099780841f7177be2100e674c1a1:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

codesandbox-ci[bot] avatar Sep 09 '22 11:09 codesandbox-ci[bot]



Test summary

3969 0 6 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 5f76cb0c2c
Started Nov 23, 2022 2:33 PM
Ended Nov 23, 2022 2:40 PM
Duration 06:31 💡
OS Linux Debian - 11.4
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 09 '22 11:09 cypress[bot]

@edleeks87 think i've fixed this now. Does it look ok to you?

ljemmo avatar Sep 09 '22 13:09 ljemmo

:tada: This PR is included in version 111.12.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Nov 23 '22 16:11 carbonci