carbon icon indicating copy to clipboard operation
carbon copied to clipboard

build(node, npm): remove constraint on node and npm, update actions to use node v16

Open edleeks87 opened this issue 2 years ago • 1 comments

Proposed behaviour

Removes engines and engineStrict properties from package.json file. Update GH actions to use node v16.16.0. Update dev-environment-setup docs to recommend using lts/gallium and check_node_version now checks if node version is v14.16.0 or above.

Current behaviour

Constrains node and npm versions to lts/fermium, actions also use that version, node version checks if version is greater than 14.16.0 but restricts to v14 range

Checklist

  • [x] Commits follow our style guide

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

The following CodeSandbox is an example of the broken behaviour. You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

edleeks87 avatar Aug 11 '22 15:08 edleeks87



Test summary

2848 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 85f2b1145b
Started Aug 22, 2022 1:59 PM
Ended Aug 22, 2022 2:05 PM
Duration 06:16 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 11 '22 15:08 cypress[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85f2b1145bbfd16b13871931b2d2664f7ed9e2ba:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR

codesandbox-ci[bot] avatar Aug 17 '22 12:08 codesandbox-ci[bot]

Closing in favour of #5419

edleeks87 avatar Sep 01 '22 14:09 edleeks87