carbon icon indicating copy to clipboard operation
carbon copied to clipboard

refactor(textbox): convert to typescript - FE-4840

Open mkrds opened this issue 3 years ago • 1 comments

Proposed behaviour

This PR contains Textbox TypeScript conversion fixes #5355 BREAKING CHANGE: characterLimit prop in both Textbox and Textarea is now of type number

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Testing instructions

Full regression testing of Textbox and all other Textbox based input components

mkrds avatar Aug 11 '22 09:08 mkrds



Test summary

2911 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit fb1d00eb4a
Started Sep 1, 2022 7:31 AM
Ended Sep 1, 2022 7:37 AM
Duration 05:48 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 11 '22 09:08 cypress[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb1d00eb4afd2a32376b5c2e8f33a26621b189cd:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart-typescript (forked) PR
flamboyant-moser-qhcpbq Issue #5355

codesandbox-ci[bot] avatar Aug 18 '22 08:08 codesandbox-ci[bot]

:tada: This PR is included in version 110.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Sep 01 '22 15:09 carbonci