carbon
carbon copied to clipboard
fix(definition-list): ensure links are styled correctly - FE-5293
During the introduction of design tokens, text-decoration of none was added to links when they are used in a definition-list. Links are underlined by default in the browser and we should honour this.
fixes #5240
Proposed behaviour
Current behaviour
Checklist
- [x] Commits follow our style guide
- [x] Related issues linked in commit messages if required
- [x] Screenshots are included in the PR if useful
- [x] All themes are supported if required
- [ ] Unit tests added or updated if required
- [ ] Cypress automation tests added or updated if required
- [x] Storybook added or updated if required
- [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
- [ ] Typescript
d.ts
file added or updated if required
QA
- [ ] Tested in CodeSandbox/storybook
- [ ] Add new Cypress test coverage if required
- [ ] Carbon implementation matches Design System/designs
- [ ] UI Tests GitHub check reviewed if required
Additional context
N/A
Testing instructions
This change can be seen in the story Tile -> with Definition List Default
. Link Text should be underlined.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 152deddd78731f5b4d675846ff48d1f8a10d2b3f:
Sandbox | Source |
---|---|
carbon-quickstart | Configuration |
carbon-quickstart-typescript | Configuration |
confident-aryabhata-ogfhzm | Issue #5240 |
Test summary
Run details
Project | carbon |
Status | Passed |
Commit | 288b85a438 |
Started | Aug 18, 2022 9:30 AM |
Ended | Aug 18, 2022 9:37 AM |
Duration | 06:41 💡 |
OS | Linux Debian - 10.10 |
Browser | Chrome 100 ![]() |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
:tada: This PR is included in version 110.1.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket: