carbon icon indicating copy to clipboard operation
carbon copied to clipboard

refactor(button-toggle): convert to typescript (FE-4771)

Open grabkowski opened this issue 3 years ago • 3 comments

Proposed behaviour

All component files should be refactored and converted to TypeScript.

Current behaviour

Component files are currently javascript.

Checklist

  • [x] Commits follow our style guide ~~- [ ] Related issues linked in commit messages if required~~ ~~- [ ] Screenshots are included in the PR if useful~~ ~~- [ ] All themes are supported if required~~
  • [x] Unit tests added or updated if required ~~- [ ] Cypress automation tests added or updated if required~~ ~~- [ ] Storybook added or updated if required~~ ~~- [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required~~
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

The following CodeSandbox is an example of the broken behaviour. You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

grabkowski avatar Aug 10 '22 08:08 grabkowski



Test summary

2848 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 3fee710e6e
Started Aug 19, 2022 4:43 PM
Ended Aug 19, 2022 4:48 PM
Duration 05:29 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 10 '22 09:08 cypress[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3fee710e6ef1b273f715cbd13aebc2442b2a1515:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

codesandbox-ci[bot] avatar Aug 10 '22 14:08 codesandbox-ci[bot]

If you have some time you could also refactor the button-toggle-test.stories.mdx file to .tsx in this PR

mkrds avatar Aug 11 '22 13:08 mkrds

:tada: This PR is included in version 110.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Aug 25 '22 16:08 carbonci