carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat(box): add styled-system position props - FE-5285

Open DipperTheDan opened this issue 3 years ago • 2 comments

Make styled-system's position props available for use in Box. zIndex has also been filtered out of the props.

fixes #5345

Proposed behaviour

Make styled-system position props available to use in Carbon's Box component.

Current behaviour

Position is currently not supported in Box component.

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [ ] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

Codesandbox will be supplied once build has run to completion

DipperTheDan avatar Aug 05 '22 15:08 DipperTheDan

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c93df164085614130b657989fa6b2199ea5e37f7:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
serene-shirley-m2x095 Issue #5345

codesandbox-ci[bot] avatar Aug 05 '22 15:08 codesandbox-ci[bot]



Test summary

2896 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit ec24477131
Started Aug 26, 2022 1:28 PM
Ended Aug 26, 2022 1:35 PM
Duration 06:41 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 05 '22 15:08 cypress[bot]

:tada: This PR is included in version 110.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Aug 30 '22 13:08 carbonci