carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat(portrait): convert component to typescript - FE-4821

Open mkrds opened this issue 3 years ago • 3 comments

Proposed behaviour

This PR contains Portrait component TS conversion

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Testing instructions

Portrait component regression

mkrds avatar Aug 02 '22 18:08 mkrds

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b1f18bac32b7882c64f5c64c2ec6e90b32fb850:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

codesandbox-ci[bot] avatar Aug 02 '22 18:08 codesandbox-ci[bot]



Test summary

2873 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 5b1f18bac3
Started Aug 24, 2022 10:42 AM
Ended Aug 24, 2022 10:47 AM
Duration 05:43 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 10 '22 15:08 cypress[bot]

is there a new feature that is implemented with the refactor? If not, then the commit should be a refactor, as it would not affect developers that are using Carbon.

grabkowski avatar Aug 11 '22 09:08 grabkowski

:tada: This PR is included in version 110.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Aug 25 '22 16:08 carbonci