carbon
carbon copied to clipboard
feat(portrait): convert component to typescript - FE-4821
Proposed behaviour
This PR contains Portrait component TS conversion
Checklist
- [x] Commits follow our style guide
- [x] Related issues linked in commit messages if required
- [x] Screenshots are included in the PR if useful
- [x] All themes are supported if required
- [x] Unit tests added or updated if required
- [x] Cypress automation tests added or updated if required
- [x] Storybook added or updated if required
- [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
- [x] Typescript
d.tsfile added or updated if required
QA
- [ ] Tested in CodeSandbox/storybook
- [ ] Add new Cypress test coverage if required
- [ ] Carbon implementation matches Design System/designs
- [ ] UI Tests GitHub check reviewed if required
Testing instructions
Portrait component regression
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 5b1f18bac32b7882c64f5c64c2ec6e90b32fb850:
| Sandbox | Source |
|---|---|
| carbon-quickstart | Configuration |
| carbon-quickstart-typescript | Configuration |
Test summary
Run details
| Project | carbon |
| Status | Passed |
| Commit | 5b1f18bac3 |
| Started | Aug 24, 2022 10:42 AM |
| Ended | Aug 24, 2022 10:47 AM |
| Duration | 05:43 💡 |
| OS | Linux Debian - 10.10 |
| Browser | Chrome 100 |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
is there a new feature that is implemented with the refactor? If not, then the commit should be a refactor, as it would not affect developers that are using Carbon.
:tada: This PR is included in version 110.1.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket: