carbon icon indicating copy to clipboard operation
carbon copied to clipboard

fix(popover-container): remove incorrect role attribute - FE-5249

Open mkrds opened this issue 3 years ago • 2 comments

Proposed behaviour

Fixes #5286

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Testing instructions

The following CodeSandbox is an example of the broken behaviour. You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

mkrds avatar Jul 26 '22 14:07 mkrds

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 964bfccdcd605c8e59be4b76f05845d2bed8328b:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
quirky-artem-zqxwrl PR
delicate-feather-084e6b Issue #5286

codesandbox-ci[bot] avatar Jul 26 '22 14:07 codesandbox-ci[bot]



Test summary

2912 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 964bfccdcd
Started Sep 2, 2022 8:54 AM
Ended Sep 2, 2022 9:00 AM
Duration 05:48 💡
OS Linux Debian - 10.10
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Jul 26 '22 14:07 cypress[bot]

Using provided codesandbox - https://codesandbox.io/s/runtime-fire-8s58vh - testing using Axe and landmark violation is now not presented therefore passing a11y review which this was fixing.

harpalsingh avatar Aug 23 '22 11:08 harpalsingh

:tada: This PR is included in version 110.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Sep 02 '22 09:09 carbonci