carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Change background color for FlatTableCell

Open WojciechMichalowski opened this issue 2 years ago • 1 comments

Desired behaviour

FlatTableCell should have prop background-color

Current behaviour

FlatTableCell don't have prop background-color

Suggested Solution

No response

CodeSandbox or Storybook URL

No response

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

WojciechMichalowski avatar Jun 13 '22 08:06 WojciechMichalowski

Your designers should be creating designs inline with what the Design System shows as usage for the FlatTable component. Looking at the screenshot from the attached PR, the subRows being rendered are not currently possible without using the expandable row pattern. If this is required your designer should consult with DS to see if this should be a standard pattern across Sage products

nicktitchmarsh avatar Jun 14 '22 13:06 nicktitchmarsh

@ljemmo any thoughts

edleeks87 avatar Nov 08 '22 13:11 edleeks87

So we deliberately suggested the gray colour for child rows within a table accordion. This was to make the child rows have the affordance that these gray rows were 'underneath' the parent row.

Based on the screenshot here i'm unsure if we would want to support this from a DS perspective. @WojciechMichalowski please can you get your designer to reach out to us and explain the rationale so we can review properly.

ljemmo avatar Nov 08 '22 15:11 ljemmo

I'm going to close this issue, it can be reopened if there are any recommendations from DS regarding this

nicktitchmarsh avatar Nov 15 '22 14:11 nicktitchmarsh