carbon icon indicating copy to clipboard operation
carbon copied to clipboard

fix(definition-list): correct font styling of dt and dd elements

Open Parsium opened this issue 2 years ago • 2 comments

Proposed behaviour

  • Make dt elements use Sage UI Medium font (design token not used due to current font weight discrepancies between Carbon and Design System which are being addressed).
  • Make dd elements use Sage UI Regular font.
  • Add underline back to links within DefinitionList to match Design System guidelines on links.
Screenshot 2022-04-21 at 11 30 45

Current behaviour

  • All text elements within DefinitionList use Sage UI Medium. Screenshot 2022-04-21 at 11 31 08

Checklist

  • [x] Commits follow our style guide
  • [x] Related issues linked in commit messages if required
  • [x] Screenshots are included in the PR if useful
  • [x] All themes are supported if required
  • [x] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [x] Storybook added or updated if required
  • [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [x] Typescript d.ts file added or updated if required

QA

  • [ ] Tested in CodeSandbox/storybook
  • [ ] Add new Cypress test coverage if required
  • [ ] Carbon implementation matches Design System/designs
  • [ ] UI Tests GitHub check reviewed if required

Testing instructions

Double check dd and dt elements are using the correct font variants as described in the proposed changes.

Parsium avatar Apr 21 '22 10:04 Parsium

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60826dfc07ddbbfd25df71eac173cb1db4965807:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

codesandbox-ci[bot] avatar Apr 21 '22 10:04 codesandbox-ci[bot]



Test summary

3464 0 3 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 60826dfc07
Started Oct 27, 2022 10:22 AM
Ended Oct 27, 2022 10:28 AM
Duration 06:15 💡
OS Linux Debian - 11.4
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Apr 21 '22 10:04 cypress[bot]

While we stil have to update all fonts where we re-set the 500/700/900 weights, this PR only updates 400 and looks all good to me in the storybook test, so this font PR can be progressed.

harpalsingh avatar Oct 21 '22 08:10 harpalsingh

:tada: This PR is included in version 111.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Oct 27 '22 10:10 carbonci