carbon
carbon copied to clipboard
fix(definition-list): correct font styling of dt and dd elements
Proposed behaviour
- Make
dt
elements useSage UI Medium
font (design token not used due to current font weight discrepancies between Carbon and Design System which are being addressed). - Make
dd
elements useSage UI Regular
font. - Add underline back to links within
DefinitionList
to match Design System guidelines on links.

Current behaviour
- All text elements within
DefinitionList
useSage UI Medium
.
Checklist
- [x] Commits follow our style guide
- [x] Related issues linked in commit messages if required
- [x] Screenshots are included in the PR if useful
- [x] All themes are supported if required
- [x] Unit tests added or updated if required
- [x] Cypress automation tests added or updated if required
- [x] Storybook added or updated if required
- [x] Translations added or updated (including creating or amending translation keys table in storybook) if required
- [x] Typescript
d.ts
file added or updated if required
QA
- [ ] Tested in CodeSandbox/storybook
- [ ] Add new Cypress test coverage if required
- [ ] Carbon implementation matches Design System/designs
- [ ] UI Tests GitHub check reviewed if required
Testing instructions
Double check dd
and dt
elements are using the correct font variants as described in the proposed changes.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 60826dfc07ddbbfd25df71eac173cb1db4965807:
Sandbox | Source |
---|---|
carbon-quickstart | Configuration |
carbon-quickstart-typescript | Configuration |
Test summary
Run details
Project | carbon |
Status | Passed |
Commit | 60826dfc07 |
Started | Oct 27, 2022 10:22 AM |
Ended | Oct 27, 2022 10:28 AM |
Duration | 06:15 💡 |
OS | Linux Debian - 11.4 |
Browser | Chrome 106 ![]() |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
While we stil have to update all fonts where we re-set the 500/700/900 weights, this PR only updates 400 and looks all good to me in the storybook test, so this font PR can be progressed.
:tada: This PR is included in version 111.8.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket: