carbon icon indicating copy to clipboard operation
carbon copied to clipboard

test(profile): add refactored tests for profile component FE-4563

Open divyajindel opened this issue 2 years ago • 3 comments

Proposed behaviour

Refactor for Profile component to use new cypress-component-react framework for testing. I have added profile.test.js and deleted profile.steps.js and profile.feature file.

Current behaviour

Currently we are using the regular cypress approach with BDD.

Checklist

  • [ ] Commits follow our style guide
  • [ ] Related issues linked in commit messages if required
  • [ ] Screenshots are included in the PR if useful
  • [ ] All themes are supported if required
  • [ ] Unit tests added or updated if required
  • [x] Cypress automation tests added or updated if required
  • [ ] Storybook added or updated if required
  • [ ] Translations added or updated (including creating or amending translation keys table in storybook) if required
  • [ ] Typescript d.ts file added or updated if required

QA

  • [x] Tested in CodeSandbox/storybook
  • [x] Add new Cypress test coverage if required
  • [x] Carbon implementation matches Design System/designs
  • [x] UI Tests GitHub check reviewed if required

Additional context

Testing instructions

  • [x] Run npx cypress open-ct to check if there is newly added test.file
  • [x] Check if the profile.test.js file passed
  • [x] Compare all tests were moved/refactored from .feature file -> .test.js file
  • [x] Check if all unnecessary files were deleted, including .json file

divyajindel avatar Mar 09 '22 15:03 divyajindel

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7dfae37e53a53209e87d0c0b3c3aba0363d31f9:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR

codesandbox-ci[bot] avatar Mar 09 '22 15:03 codesandbox-ci[bot]



Test summary

1619 0 2 0Flakiness 0


Run details

Project carbon
Status Passed
Commit e7dfae37e5
Started Mar 22, 2022 2:24 PM
Ended Mar 22, 2022 2:30 PM
Duration 05:33 💡
OS Linux Debian - 10.9
Browser Chrome 91

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Mar 09 '22 15:03 cypress[bot]

it fails locally. So my suggestion is to provide some ENV or use the existing one and just use a regular if with different files to compare from ci and locally

DlgSHi avatar Mar 17 '22 12:03 DlgSHi