carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Add padding props to Sidebar

Open liam-cochrane opened this issue 3 years ago • 5 comments

Desired behaviour

I would like to customise the padding within a sidebar component so that the content within can span across the entire width of the sidebar.

Current behaviour

It is not possible to change the padding within the sidebar without writing custom CSS.

Suggested Solution

No response

CodeSandbox or Storybook URL

https://codesandbox.io/s/floral-pine-hd3zt?file=/src/index.js

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

liam-cochrane avatar Oct 18 '21 13:10 liam-cochrane

@harpalsingh - What is your opinion on adding the padding props to Sidebar?

DipperTheDan avatar Oct 19 '21 12:10 DipperTheDan

From the DS team: I would expect the header and the footer to have set padding, but the central area could in theory be used for any content. For that reason, it would be good if the padding in the central area padding could be adapted according to requirements. In the case when there are no specific requirements, the default padding should be used.

clairedenning avatar Nov 09 '21 10:11 clairedenning

FE-4458

DlgSHi avatar Nov 09 '21 14:11 DlgSHi

@clairedenning please could you make sure that this change is reflected in the DS docs and we will schedule in the change.

nicktitchmarsh avatar Nov 10 '21 10:11 nicktitchmarsh

Hi, as our team hasn't yet "migrated" the component (ie analysed, fixed, enhanced, documented, etc...) it may be a while before the documentation is added. But I will update the backlog with this request.

clairedenning avatar Nov 10 '21 11:11 clairedenning

:tada: This issue has been resolved in version 110.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Aug 17 '22 15:08 carbonci

I believe we have a new ticket for this in an upcoming sprint https://jira.sage.com/browse/DSY-2267, is that right @ingridzillinger ?

clairedenning avatar Jan 30 '23 17:01 clairedenning