Drake Costa
Drake Costa
I'll need to investigate this further when I have more time. Will be busy for the rest of today so I can probably get back to this tomorrow. I'm confident...
> Adding `type: string;` to `BaseSchema` and `BaseValidation` adds more problems than it solves, in my opinion. The current implementation provides complete type safety when schemas are processed by other...
Hey just wanted to give a quick status update: I've been rather busy this week and I haven't spent more than an hour investigating a path forward yet. I'll circle...
With the `schemaToJson` example first of all I just want to point out that in either implementation (types or interface), there is a type error for the inferred return type...
Maybe just `hasType`? `isOfType` was just the name I found in some stackoverflow answer, so I'm not committed to it. Same with the argument names. I only really think the...
> I noticed that you're using snake_case for validation type, for example: > > ```ts > export function minLength(...) { // return { > kind: 'validation', > type: 'min_length', //...
> Do you know how other schema libraries like Zod behave in this regards? `zod` appears to have a Promise schema, which according to it's documentation does validation in a...
Requesting the same thing in #257 essentially. `BaseSchema`, `BaseValidation`, and `BaseTransform` should all be interfaces that describe the most generic shape of the return values for each of those function...
So, I think I would be okay with a Union export for all of the schema types because it doesn't add any weight to the package since it's just type...
I haven't personally run into that issue with `instanceof` before. Could [`Symbol.hasInstance`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/hasInstance) be a possible solution to this? I'm not entirely sure from reading it. And I'm also not quite...