[Problem] v3.3.0 misinterpreting RedumperLeadinRetryCount setting as drive speed

[periodic1236]

Version

• Stable release v3.3.0 (2025-01-03)

Build What runtime version are you using?

• .NET 9.0 running on Windows 11 x64

Describe the issue If I enable "Set Default Plextor Lead-in Retries" under Tools > Options > Programs > Redumper, the retry count value (which defaults to 4) is passed to redumper in the speed parameter, regardless of what is chosen for the Drive Speed. If I put a custom retry count, the same number shows up in the Parameters box but is attached to the --speed flag, not the --plextor-leadin-retries argument (which is missing). Indeed, if I start the dump, redumper is invoked with --speed=4 or similar.

To Reproduce Steps to reproduce the behavior:

1. Start MPF.UI with a fresh config (delete config.json).
2. Set "Media Type" to Audio CD, observe default "Drive Speed" for CD-ROM is set to 24 and --speed=24 appears in the "Parameters" box.
3. Change "Drive Speed" to 8, observe --speed=8 in the "Parameters" box.
4. Enable "Set Default Plextor Lead-in Retries", observe that it now has --speed=4.
5. Change "Drive Speed" to 16, observe that it still shows --speed=4.
6. Change "Plextor Lead-in Retries" to 123, observe --speed=123 now.

Expected behavior For redumper, the --speed flag should be correctly set to the chosen drive speed, and the Plextor lead-in retry count value should be passed to the --plextor-leadin-retries flag.

[Deterous]

Here's where the issue is: https://github.com/SabreTools/MPF/blob/679b40de7c089c3705ef008fbb720f6a4eabc6f1/MPF.ExecutionContexts/Redumper/ExecutionContext.cs#L344

In the meantime, you'll have to disable the setting and manually add the --plextor-leadin-retries flag to the custom parameters