Sabine Haas
Sabine Haas
Ah, I've also noticed that some of the units are missing in KPI_SCALARS_DICT
pvcompare might be restructured soon (rtd) so I would add the links afterwards - now the parameter description is a chaos.. Would you like to have a link like that...
I started to write docstrings when writing the test function names. Started for C1 in #152. I think this makes sense as I need to understand the functionality for testing...
I checked the boxes of the modules that do have docstrings already. And wrote some todos behind the boxes I didn't check. Feel free to add your names to the...
@smartie2076 I moved this issue to "Late Issues" as now it's working (give higher prio to bugs and necessary enhancements)
So seems like there actually is a problem when `maximumCap < installedCap` (checkout errors in `E0` of this PR --> #833), which is probably the reason why we first adapted...
For me both options seem right, intuitive and okay, as long as the definition of the parameters is documented well.
> @Bachibouzouk @SabineHaas were you aware of this? Should we store the json file that results from reading the csv files one level up, directly `[OUTPUT_PATH]`? I wasn't aware of...
@Piranias could you please check whether @smartie2076 's proposals/questions do affect pvcompare in a way you could not handle well?
> * Should `mvs_csv_config.json` be stored without the `F0.store_as_json` function? I would think it should use `F0.store_as_json`. > You mean one of the files starting with `json_` right? > *...