Sabaki icon indicating copy to clipboard operation
Sabaki copied to clipboard

Feature suggestion: Move Numbers options

Open David53bcg opened this issue 4 years ago • 7 comments

It might be helpful for study to have a couple of additional options for move numbering to show a lesser number than the full game:

  • Numbering last x moves as a fixed preference, still showing their correct numbers in the game sequence
  • Numbering next y moves from '1' anywhere in the game, as a toggle feature for both play and replay

David53bcg avatar Dec 09 '20 19:12 David53bcg

I agree. Having all move numbers is too busy much of the time.

[Edited:] The current move number is shown in the scroll bar of the game tree.

goodger avatar Dec 30 '20 20:12 goodger

It would be very useful to automatically number the moves within variations, like on OGS.

goodger avatar Jan 27 '21 04:01 goodger

* Numbering next y moves from '1' anywhere in the game, as a toggle feature for both play and replay

@David53bcg How do you envision this one being implemented in practice? What exactly do you mean by "toggle feature for both play and replay"?

kevinsung avatar Sep 22 '21 11:09 kevinsung

@David53bcg I have opened #826 to address this issue. I added options to number the variation, or from a hotspot. I believe these are sufficient to address nearly all practical use cases, so I marked the PR as fixing this issue. Let me know if you disagree.

kevinsung avatar Sep 22 '21 18:09 kevinsung

@kevinsung: Looks good to me. Thank you!

goodger avatar Sep 23 '21 02:09 goodger

@kevinsung: Many thanks for addressing this issue so well. Greatly appreciated. This improvement will make it so much easier to study middle-game problems/variation, where the clutter of whole-board numbering can be a distraction.

David53bcg avatar Sep 23 '21 09:09 David53bcg

@kevinsung: What I meant by ‘toggle … for both play and replay’, is that the ‘number-from-now’ feature should be available during a live game, as well as in review/replay, and that you can switch the feature on and off. This is useful (for example) when you’re playing an AI game and want to observe closely how a particular sequence plays out, but then want to clear all numbering while you play on. Your samples suggest that this should be perfectly possible using Hotspot.

Again thanks!

Best wishes,

David

From: Kevin J. Sung @.> Sent: 22 September 2021 12:54 To: SabakiHQ/Sabaki @.> Cc: David53bcg @.>; Mention @.> Subject: Re: [SabakiHQ/Sabaki] Feature suggestion: Move Numbers options (#758)

  • Numbering next y moves from '1' anywhere in the game, as a toggle feature for both play and replay

@David53bcg https://github.com/David53bcg How do you envision this one being implemented in practice? What exactly do you mean by "toggle feature for both play and replay"?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SabakiHQ/Sabaki/issues/758#issuecomment-924857763 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ARX2CCNSSEA5FGVBTOUBUGTUDG7VTANCNFSM4UT6BIIA . https://github.com/notifications/beacon/ARX2CCKVFUUJ7YCE6QUHPZDUDG7VTA5CNFSM4UT6BIIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG4QDLIY.gif

David53bcg avatar Sep 23 '21 09:09 David53bcg