BetterDiscordAddons icon indicating copy to clipboard operation
BetterDiscordAddons copied to clipboard

[Suggestion] Cooperative request

Open phoriah opened this issue 3 years ago • 86 comments

I have found another group of people trying to fix this big issue. here All I'm saying is if you could potentially team up with them and unite your efforts I think that'd be great. If more similar projects arise I will try to notify you and them. Just a suggestion! Thanks, P.

phoriah avatar Sep 05 '22 16:09 phoriah

Thank you for bringing this to my intention! That'd definitely be cool. Paging @xAstroBoy

Saalvage avatar Sep 05 '22 20:09 Saalvage

Saalvage's version of the add-on is much better, as it doesn't require its own version of 0BDFDB, which breaks all add-ons using it. The maintainer of the other fork seems uncooperative to actually fix the problem and just asks us to "switch to replugged" (an alternative to better discord) as a crutch.

Thank you for this fork @Saalvage ❤ And thank you @phoriah to made me find this fork by opening a similar issue in the other repo.

mutageneral avatar Sep 05 '22 20:09 mutageneral

The other repo seems to have been deleted. This was not the intention of my comments.

@teisseire117 If you could not see my comment before the repo was deleted, I said I found a fix to the issues we both had by using this fork of instead.

mutageneral avatar Sep 05 '22 20:09 mutageneral

Yeah, i deleted because this fork already has a better fix than my repo, but as i mentioned, i moved to replugged and installed this

https://github.com/discord-modifications/show-hidden-channels

xAstroBoy avatar Sep 05 '22 20:09 xAstroBoy

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas


Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

mutageneral avatar Sep 05 '22 20:09 mutageneral

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas

Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

Because discord updates tend to break the library, hence i always suggest to move to replugged and install the replugged one's and for BD plugins, use bdcompat, as it allows them to work, just dont use devilbro's ones.

xAstroBoy avatar Sep 05 '22 20:09 xAstroBoy

I suggest yall take a chill pill, hardcoding stuff from the data file will solve it for now, but upcoming updates can easily screw up the strat, my suggestion is a rewrite but I ain't got the time nor skill for that

dimaguy avatar Sep 05 '22 20:09 dimaguy

I suggest yall take a chill pill, hardcoding stuff from the data file will solve it for now, but upcoming updates can easily screw up the strat, my suggestion is a rewrite but I ain't got the time nor skill for that

Yeah, a rewrite to break free of the 0BDB library is a better way for showhiddenchannel to survive all the discord updates.

xAstroBoy avatar Sep 05 '22 20:09 xAstroBoy

Hoping for the best of this! Removing one of the best plugins was really uncalled for on their end.

phoriah avatar Sep 05 '22 20:09 phoriah

It wasn't uncalled for, there were reasons behind it. But after all, its free stuff. We are not entitled to it by any means

dimaguy avatar Sep 05 '22 20:09 dimaguy

Do you mind listing the reasons? Simply curious.

phoriah avatar Sep 05 '22 20:09 phoriah

The other repo seems to have been deleted. This was not the intention of my comments.

@teisseire117 If you could not see my comment before the repo was deleted, I said I found a fix to the issues we both had by using this fork of instead.

Thank you but this doesn't work, it has the same issue as the one from the previous repository, but they had fixed it somehow.

Basically it still auto-deletes itself

Lyfhael avatar Sep 05 '22 21:09 Lyfhael

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

Because discord updates tend to break the library, hence i always suggest to move to replugged and install the replugged one's and for BD plugins, use bdcompat, as it allows them to work, just dont use devilbro's ones.

The thing is Devilbro made over 50 plug-ins and people use a lot of them, they definitely make the Discord experience a lot more enjoyable

Lyfhael avatar Sep 05 '22 21:09 Lyfhael

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

Because discord updates tend to break the library, hence i always suggest to move to replugged and install the replugged one's and for BD plugins, use bdcompat, as it allows them to work, just dont use devilbro's ones.

The thing is Devilbro made over 50 plug-ins and people use a lot of them, they definitely make the Discord experience a lot more enjoyable

most of them cause instability, there's some plugins being rewritten for replugged/powercord.

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

The way I see it: I assume 0BDB abstracts away a large portion of the underlying stuff within Discord that might break between updates, meaning sticking with 0BDB will actually allow us to survive longer. Especially when considering that with each update changing 0BDB's API we have a huge amount of other plugins to observe the plugin conversion process (all of DevilBro's plugins), meaning converting ourselves might not be so hard!

"Rewriting" SHC would probably just come down to inlining most 0BDB's methods it's using and I personally do not believe that to be the best way forward.

Saalvage avatar Sep 05 '22 21:09 Saalvage

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

Because discord updates tend to break the library, hence i always suggest to move to replugged and install the replugged one's and for BD plugins, use bdcompat, as it allows them to work, just dont use devilbro's ones.

The thing is Devilbro made over 50 plug-ins and people use a lot of them, they definitely make the Discord experience a lot more enjoyable

most of them cause instability, there's some plugins being rewritten for replugged/powercord.

Would it be possible to use his plugins excluding SHC which would be ran from replugged?

phoriah avatar Sep 05 '22 21:09 phoriah

The way I see it: I assume 0BDB abstracts away a large portion of the underlying stuff within Discord that might break between updates, meaning sticking with 0BDB will actually allow us to survive longer. Especially when considering that with each update changing 0BDB's API we have a huge amount of other plugins to observe the plugin conversion process (all of DevilBro's plugins), meaning converting ourselves might not be so hard!

"Rewriting" SHC would probably just come down to inlining most 0BDB's methods it's using and I personally do not believe that to be the best way forward.

Take a look at https://github.com/discord-modifications/show-hidden-channels , it doesn't rely on 0BDB library

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

On a side note: I'd like to keep the discussion surrounding all of the drama to remain off this repo, as it's not really the place for it. feel free to head over to /r/OpenBetterDiscord to discuss that and keep this repo to code related matters, thanks!

Saalvage avatar Sep 05 '22 21:09 Saalvage

The other repo seems to have been deleted. This was not the intention of my comments. @teisseire117 If you could not see my comment before the repo was deleted, I said I found a fix to the issues we both had by using this fork of instead.

Thank you but this doesn't work, it has the same issue as the one from the previous repository, but they had fixed it somehow.

Basically it still auto-deletes itself

What I did to fix the issue is to delete 0BDFDB & ShowHiddenChannels from my plugin folder. Then I took https://github.com/Saalvage/BetterDiscordAddons/blob/master/Plugins/ShowHiddenChannelsV2/ShowHiddenChannelsV2.plugin.js and put it in my plugin folder and enabled it and reloaded discord. On reload, it prompted me to install the latest version of 0BDFDB. I did and restarted and now everything works flawlessly.

mutageneral avatar Sep 05 '22 21:09 mutageneral

The way I see it: I assume 0BDB abstracts away a large portion of the underlying stuff within Discord that might break between updates, meaning sticking with 0BDB will actually allow us to survive longer. Especially when considering that with each update changing 0BDB's API we have a huge amount of other plugins to observe the plugin conversion process (all of DevilBro's plugins), meaning converting ourselves might not be so hard! "Rewriting" SHC would probably just come down to inlining most 0BDB's methods it's using and I personally do not believe that to be the best way forward.

Take a look at https://github.com/discord-modifications/show-hidden-channels , it doesn't rely on 0BDB library

But I believe the underlying API for Powercord is different from BetterDiscord?

Actually, does Powercord have good docs? Because the ones for BetterDiscord are absolutely horrendous.

If they do I might just switch myself!

Saalvage avatar Sep 05 '22 21:09 Saalvage

The way I see it: I assume 0BDB abstracts away a large portion of the underlying stuff within Discord that might break between updates, meaning sticking with 0BDB will actually allow us to survive longer. Especially when considering that with each update changing 0BDB's API we have a huge amount of other plugins to observe the plugin conversion process (all of DevilBro's plugins), meaning converting ourselves might not be so hard! "Rewriting" SHC would probably just come down to inlining most 0BDB's methods it's using and I personally do not believe that to be the best way forward.

Take a look at https://github.com/discord-modifications/show-hidden-channels , it doesn't rely on 0BDB library

But I believe the underlying API for Powercord is different from BetterDiscord?

Actually, does Powercord have good docs? Because the ones for BetterDiscord are absolutely horrendous.

If they do I might just switch myself!

feel free to ask in their discord https://replugged.dev/installation

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

The other repo seems to have been deleted. This was not the intention of my comments. @teisseire117 If you could not see my comment before the repo was deleted, I said I found a fix to the issues we both had by using this fork of instead.

Thank you but this doesn't work, it has the same issue as the one from the previous repository, but they had fixed it somehow. Basically it still auto-deletes itself

What I did to fix the issue is to delete 0BDFDB & ShowHiddenChannels from my plugin folder. Then I took https://github.com/Saalvage/BetterDiscordAddons/blob/master/Plugins/ShowHiddenChannelsV2/ShowHiddenChannelsV2.plugin.js and put it in my plugin folder and enabled it and reloaded discord. On reload, it prompted me to install the latest version of 0BDFDB. I did and restarted and now everything works flawlessly.

That works thank you.

Lyfhael avatar Sep 05 '22 21:09 Lyfhael

MessageLoggerV2 seems to be good example of how plugin survives after being exiled

phoriah avatar Sep 05 '22 21:09 phoriah

MessageLoggerV2 seems to be good example of how plugin survives after being exiled

yeah and they even say that it will die LMAO

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

@xAstroBoy what is the difference between powercord and replugged? replugged seems to be a fork of powercord.

mutageneral avatar Sep 05 '22 21:09 mutageneral

@xAstroBoy what is the difference between powercord and replugged? replugged seems to be a fork of powercord.

is a fork of powercord, is the same base, because powercord is obsolete.

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

The way I see it: I assume 0BDB abstracts away a large portion of the underlying stuff within Discord that might break between updates, meaning sticking with 0BDB will actually allow us to survive longer. Especially when considering that with each update changing 0BDB's API we have a huge amount of other plugins to observe the plugin conversion process (all of DevilBro's plugins), meaning converting ourselves might not be so hard! "Rewriting" SHC would probably just come down to inlining most 0BDB's methods it's using and I personally do not believe that to be the best way forward.

Take a look at https://github.com/discord-modifications/show-hidden-channels , it doesn't rely on 0BDB library

yes but how do you install that

Minixsas avatar Sep 05 '22 21:09 Minixsas

Quote reply

use replugged and use git clone in the replugged plugins folder.

xAstroBoy avatar Sep 05 '22 21:09 xAstroBoy

I found another repo with the same goal to continue ShowHiddenChannels: https://github.com/Minixsas/ShowHiddenChannelsFix Could be cool to cooperate with them? Ping to the maintainers: @dimaguy & @Minixsas

Also, @Saalvage, they mention this on their readme:

In it's current state it won't survive main library updates

Is this true for this add-on too? Next 0BDFDB update we are screwed?

when he updates the library we can most likely apply the same patch to the new library as we did to the old one (current one)

Minixsas avatar Sep 05 '22 21:09 Minixsas

I already got banned on bd discord for sending people the shc fix

Minixsas avatar Sep 05 '22 21:09 Minixsas