SW van Heerden

Results 42 issues of SW van Heerden

We have been trying to support duplicate wallets. Most of the code seems to be working fine, except when the duplicate wallets connect to the same base node, then their...

Currently, the FFI only supports error codes but they are meaningless without the source code listing the error codes. We should add optional error return types. The create getters and...

E-good_first_issue
A-wallet-ffi

Currently, not all bad behaviour is punished in the comms layer: - [x] SAF/Store: the message has no signature - [x] SAF_handler/task: invalid saf message - [ ] SAF_handler/task: peer...

P-high-risk

Currently the call `pub unsafe extern "C" fn wallet_get_last_version(config: *mut TariCommsConfig, error_out: *mut c_int) -> *mut c_char` take in the entire `TariCommsConfig`, this is not needed and we can reduce...

We need to ensure that we store the base node tor key in a safe location, currently, the file locked to a user, but its not really safe as its...

P-high-risk

Protobuf messages can have extra fields in the messages that are not shown by the proto file, This can increase message size up to the frame size and allow peers...

P-high-risk

The wallet should be able to ban peers as well.

We determine the number of TCP nodes by looking at the connection address. For inbound connections are currently always TCP regardless of transport. For tor, they always reflect the inbound...

Sync update: `self.hooks.call_on_starting_hook` drains the peer list, so it will only work for the first peer. https://github.com/tari-project/tari/blob/6c8e2d395799757e5a946fe01226f739d0706741/base_layer/core/src/base_node/sync/hooks.rs#L49C11-L49C11

If the node receives an invalid chain metadata it should ban the peer