swish
swish copied to clipboard
SWI-Prolog
Back button causes fullscreen
I've noticed some unexpected behavior with the back button when using http://swish.swi-prolog.org/
The back-button sometimes doesn't do anything but when it does it results in the previous notebook always in full screen mode. I've reproduced this on Chrome and Safari browsers.
Notebooks open full screen. The back button is largely broken. The little attempt to handle it properly probably made it worse. That part needs rethinking. We probably should also use the browser local store to make the history and (some of the) state persistent. One example might be the full screen state of notebooks.
If you want to look into it ...
Cheers --- Jan
On 10/05/2016 11:26 PM, edechter wrote:
I've noticed some unexpected behavior with the back button when using http://swish.swi-prolog.org/
The back-button sometimes doesn't do anything but when it does it results in the previous notebook always in full screen mode. I've reproduced this on Chrome and Safari browsers.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7cqhFKhno51TM4KuF2J1hivww0vZCRks5qxBX1gaJpZM4KPTpQ.
On Thu, Oct 6, 2016 at 2:50 AM, Jan Wielemaker [email protected] wrote:
Notebooks open full screen.
If I go to http://swish.swi-prolog.org/ and click on an example notebook from the menu, it doesn't open fullscreen. Is it supposed to?
The back button is largely broken. The little attempt to handle it properly probably made it worse. That part needs rethinking. We probably should also use the browser local store to make the history and (some of the) state persistent. One example might be the full screen state of notebooks.
If you want to look into it ...
I think that the back button doesn't need to work all that well if navigating to a different page 1) alerted the user that the state of the open notebooks will be lost and 2) if there were a application back button. The full screen modes feels like a different page, so I used the browser back button, and the close full-screen button is sort of hidden.
Eyal
Cheers --- Jan
On 10/05/2016 11:26 PM, edechter wrote:
I've noticed some unexpected behavior with the back button when using http://swish.swi-prolog.org/
The back-button sometimes doesn't do anything but when it does it results in the previous notebook always in full screen mode. I've reproduced this on Chrome and Safari browsers.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7cqhFKh no51TM4KuF2J1hivww0vZCRks5qxBX1gaJpZM4KPTpQ>.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43#issuecomment-251881127, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhn3ntI_gRylwYTfPlKnhnBJo7E6tzmks5qxJorgaJpZM4KPTpQ .
On 10/07/16 16:57, edechter wrote:
On Thu, Oct 6, 2016 at 2:50 AM, Jan Wielemaker [email protected] wrote:
Notebooks open full screen.
If I go to http://swish.swi-prolog.org/ and click on an example notebook from the menu, it doesn't open fullscreen. Is it supposed to?
No, it is not. It is supposed to open fullscreen if you go directly to the address of the notebook. The idea is that you can use the URL of a notebook that deploys a complete application without ever seeing the complete SWISH interface.
The back button is largely broken. The little attempt to handle it properly probably made it worse. That part needs rethinking. We probably should also use the browser local store to make the history and (some of the) state persistent. One example might be the full screen state of notebooks.
If you want to look into it ...
I think that the back button doesn't need to work all that well if navigating to a different page 1) alerted the user that the state of the open notebooks will be lost and 2) if there were a application back button. The full screen modes feels like a different page, so I used the browser back button, and the close full-screen button is sort of hidden.
I see your confusion. Thanks. Won't happen soon, but this should be considered when revising history management and fullscreen management,
Cheers --- Jan
Eyal
Cheers --- Jan
On 10/05/2016 11:26 PM, edechter wrote:
I've noticed some unexpected behavior with the back button when using http://swish.swi-prolog.org/
The back-button sometimes doesn't do anything but when it does it results in the previous notebook always in full screen mode. I've reproduced this on Chrome and Safari browsers.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7cqhFKh no51TM4KuF2J1hivww0vZCRks5qxBX1gaJpZM4KPTpQ>.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43#issuecomment-251881127, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhn3ntI_gRylwYTfPlKnhnBJo7E6tzmks5qxJorgaJpZM4KPTpQ .
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SWI-Prolog/swish/issues/43#issuecomment-252274858, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7cqne5IZPNRNQM1XdfDGrpBpgA0tjaks5qxl3MgaJpZM4KPTpQ.