skuba icon indicating copy to clipboard operation
skuba copied to clipboard

[WIP] Istio: Adding Traffic Management tests

Open mmnelemane opened this issue 4 years ago • 4 comments

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will appear in the changelog.

What does this PR do?

please include a brief "management" technical overview (details are in the code)

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug. If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

Info that can be relevant for QA:

  • link to other PRs that should be merged together
  • link to packages that should be released together
  • upstream issues

Status BEFORE applying the patch

How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove this issue is not fixed.

Status AFTER applying the patch

How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.

Docs

If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp. At the time of creating the issue, this PR can be work in progress (set its title to [WIP]), but the documentation needs to be finalized before the PR can be merged.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

mmnelemane avatar Aug 20 '20 09:08 mmnelemane

is this still valid @mmnelemane? has networking reviewed it @mbologna ?

It still needs an update...and it should be fast otherwise we should just close it.

Itxaka avatar Nov 10 '20 09:11 Itxaka

@Itxaka A simplified test was included in Skuba and since there was no plan to include Istio in the CaaSP release, I stopped this expansion. I think it can be closed for now unless someone still requests for Istio on CaaSP 4.5.

mmnelemane avatar Nov 10 '20 10:11 mmnelemane

I would let the branch stay, so that we can use it if needed in future.

mmnelemane avatar Nov 10 '20 10:11 mmnelemane

Thanks for the update @mmnelemane Closing the Pr does not remove the branch btw.

Itxaka avatar Nov 10 '20 11:11 Itxaka