skuba icon indicating copy to clipboard operation
skuba copied to clipboard

Security hardening for kured

Open saschagrunert opened this issue 4 years ago • 5 comments

I think we should work on security hardening for the kured DaemonSet and maybe the application itself. It runs as privileged container which seems a more general security issue from my point of view:

https://github.com/SUSE/skuba/blob/1967cc7a06fae2e59b643045f337ea2f8dab1637/internal/pkg/skuba/addons/kured.go#L158

The Weaveworks community is already aware of the issue and I would suggest:

  • Contribute to kured that we do not need to run it as privileged container any more (see https://github.com/weaveworks/kured/issues/60)
  • Wrap-up a seccomp/AppArmor profile for kured to further security harden from a k8s perspective

WDYT?

saschagrunert avatar Jul 08 '20 20:07 saschagrunert

I would be super happy to see us help here! :rocket:

flavio avatar Jul 10 '20 15:07 flavio

I think this would be a good opportunity for someone who wants to start contributing to upstream, especially because it’s important but not urgent. I’m happy to help with anything and leave this issue open for now. 😊

As background information, we found this issue by working on the seccomp-operator and evaluating possible applications where we could apply default profiles. Kured seems a good start and the profile could be contributed to the operator as well. This way we could simply utilize the operator later on to deploy default profiles in our products and in the wild. 😜

saschagrunert avatar Jul 10 '20 18:07 saschagrunert

The kucero also have this issue.

jenting avatar Jul 11 '20 02:07 jenting

I am happy to contribute there, as I already am. However, I am not sure how we can avoid that, as we need to access host though.

evrardjp avatar Aug 13 '20 07:08 evrardjp

I am happy to contribute there, as I already am. However, I am not sure how we can avoid that, as we need to access host though.

Paulo is working on a possible solution in https://github.com/weaveworks/kured/pull/172. If that’s a feasible way then we can adapt our deployment too. 🙂

saschagrunert avatar Aug 14 '20 20:08 saschagrunert