rmt
rmt copied to clipboard
Move error handling to the proper method
Description
The method that gets the activations from SCC by making a request, should be responsible to handle if the request failed
Use Rails.logger instead of carrying logger all over the methods
How to test
Activate a product on SCC,should work as expected
Change Type
Please select the correct option.
- [ ] Bug Fix (a non-breaking change which fixes an issue)
- [X] New Feature (a non-breaking change which adds new functionality)
- [ ] Documentation Update (a change which only updates documentation)
Checklist
Please check off each item if the requirement is met.
- [X] I have reviewed my own code and believe that it's ready for an external review.
- [X] I have provided comments for any hard-to-understand code.
- [ ] I have documented the
MANUAL.md
file with any changes to the user experience. - [ ] If my changes are non-trivial, I have added a changelog entry to notify users at
package/obs/rmt-server.changes
.
Review
Please check out our review guidelines and get in touch with the author to get a shared understanding of the change.