helm chart error for portus.productionPassword

[simon-scherzinger]

I tried to install Portus with the helm chart and the config .Values.portus.dbAdapter: pg. But when dry-running the installation I got an error that .Values.portus.productionPassword is not a string. I assume that it is in fact not a string, but why would I care since I am not using mariadb?

The error is in the following lines: https://github.com/kubic-project/caasp-services/blob/76419498b27644cde0b2edab5734b888d2fc75aa/contrib/helm-charts/portus/templates/portus-secret.yaml#L28-L30

Wouldn't it be better to use this instead:

{{- if and (eq .Values.mariadb.enabled false) (eq .Values.portus.dbAdapter "mysql2") }}
PORTUS_PRODUCTION_PASSWORD: {{ .Values.portus.productionPassword | b64enc | quote }}
{{- end }}

Please correct me if I'm wrong! Just started using helm. ;-)