DeepSea icon indicating copy to clipboard operation
DeepSea copied to clipboard

Hardcoded paths in deepsea

Open mkoderer opened this issue 6 years ago • 2 comments

Problem:

Deepsea salt module contains complete paths to access files, e.g. policy.cfg: https://github.com/SUSE/DeepSea/blob/v0.7.32/srv/modules/runners/validate.py#L729

With this it is not possible to use salts 'ROOT_DIR' option.

mkoderer avatar Oct 16 '17 12:10 mkoderer

We could replace the first slash with __opts__['root_dir'] which would address this.

Is there a need to replace '/srv/pillar' and '/srv/salt' with __opts__['pillar_roots']['base'][0] and __opts__['file_roots']['base'][0]?

Just for reference: https://github.com/saltstack/salt/issues/699

swiftgist avatar Apr 05 '18 19:04 swiftgist

I like that approach @swiftgist . I vote for yes to both your questions.

dreamsequins avatar May 31 '19 04:05 dreamsequins