logging

[swiftgist]

Description of Issue/Question

Remembered a recent conversation about how osd.py logging in particular needs to be improved. Part of the issue is the level of noise with log_debug and spending time understanding which previous commands contributed to a failure.

Ideally, a specific transaction for normal logging would be much more useful if all the commands and related outputs were logged together. This would also be as a log warn and only appear if something has gone wrong.

Additionally, we have issues with methods such as highest_partition. In the normal context, an error would mean a failure. In other contexts such as a call from is_prepared, an error is just confusing noise.

[smithfarm]

Real world example where someone reported this as a bug:

I can see this error message system log file on all OSD minions:

2018-08-01T11:40:24.083165+02:00 ares salt-minion[26622]: [ERROR   ] Partition type lockbox not found on /dev/sdc
2018-08-01T11:40:24.083325+02:00 ares salt 2018-08-01 11:40:24,083 [salt.loaded.ext.module.osd][ERROR   ][2521] Partition type lockbox not found on /dev/sdc
2018-08-01T11:40:24.089293+02:00 ares salt-minion[26622]: [ERROR   ] Partition type osd not found on /dev/sdc
2018-08-01T11:40:24.089451+02:00 ares salt 2018-08-01 11:40:24,089 [salt.loaded.ext.module.osd][ERROR   ][2521] Partition type osd not found on /dev/sdc