cnaas-nms
cnaas-nms copied to clipboard
Change order of ipv4_to_ipv6 arguments
As pointed out by our core CNaaS team, the argument order of the ipv4_to_ipv6 filter function was confusing, as the filter would normally be used in Jinja templates by piping a host's IPv4 address through the filter.
Codecov Report
Merging #228 (88e6270) into develop (52840ef) will decrease coverage by
4.36%
. The diff coverage isn/a
.
:exclamation: Current head 88e6270 differs from pull request most recent head dc7d90d. Consider uploading reports for the commit dc7d90d to get more accurate results
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
- Coverage 63.78% 59.41% -4.37%
===========================================
Files 63 61 -2
Lines 6627 6180 -447
===========================================
- Hits 4227 3672 -555
- Misses 2400 2508 +108
Impacted Files | Coverage Δ | |
---|---|---|
src/cnaas_nms/tools/jinja_filters.py | 18.18% <ø> (-18.56%) |
:arrow_down: |
src/cnaas_nms/api/linknet.py | 19.56% <0.00%> (-46.93%) |
:arrow_down: |
src/cnaas_nms/confpush/underlay.py | 19.60% <0.00%> (-37.26%) |
:arrow_down: |
src/cnaas_nms/db/session.py | 75.00% <0.00%> (-9.85%) |
:arrow_down: |
src/cnaas_nms/db/linknet.py | 79.71% <0.00%> (-9.32%) |
:arrow_down: |
src/cnaas_nms/db/git.py | 53.99% <0.00%> (-9.30%) |
:arrow_down: |
src/cnaas_nms/api/app.py | 68.42% <0.00%> (-8.51%) |
:arrow_down: |
src/cnaas_nms/confpush/init_device.py | 50.11% <0.00%> (-7.88%) |
:arrow_down: |
src/cnaas_nms/api/repository.py | 54.76% <0.00%> (-7.15%) |
:arrow_down: |
... and 33 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Putting this into draft status, as our team keeps changing their minds about how this function should ultimately work.
Will get back to a proper PR once our design is (hopefully) stabilized
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
41 Security Hotspots
2 Code Smells
No Coverage information
0.0% Duplication