Allow having two uplinks to stack

[stveit]

As a stack is still a single device, multiple links between devices must be supported to be able to have two uplinks to a stack. Draft changes trying to figure out what needs to be changed/what restrictions should there be to make this work properly.

current changes mostly change some code that assume one interface per neighbor into allowing multiple interfaces and removing any related restrictions.

[codecov[bot]]

Codecov Report

Base: 44.74% // Head: 59.59% // Increases project coverage by +14.85% :tada:

Coverage data is based on head (23aeb9d) compared to base (cede4dd). Patch coverage: 23.68% of modified lines in pull request are covered.

:exclamation: Current head 23aeb9d differs from pull request most recent head c8b3211. Consider uploading reports for the commit c8b3211 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #217       +/-   ##
============================================
+ Coverage    44.74%   59.59%   +14.85%     
============================================
  Files           64       60        -4     
  Lines         6636     6083      -553     
============================================
+ Hits          2969     3625      +656     
+ Misses        3667     2458     -1209     

Impacted Files	Coverage Δ
src/cnaas_nms/confpush/sync_devices.py	70.42% <0.00%> (+4.62%)	:arrow_up:
src/cnaas_nms/db/device.py	73.63% <ø> (+27.45%)	:arrow_up:
src/cnaas_nms/confpush/get.py	60.26% <22.22%> (+7.70%)	:arrow_up:
src/cnaas_nms/db/linknet.py	67.85% <27.77%> (-13.86%)	:arrow_down:
src/cnaas_nms/db/helper.py	62.71% <50.00%> (+12.04%)	:arrow_up:
src/cnaas_nms/tools/jinja_filters.py	14.70% <0.00%> (-22.03%)	:arrow_down:
src/cnaas_nms/confpush/init_device.py	50.11% <0.00%> (-6.96%)	:arrow_down:
src/cnaas_nms/confpush/changescore.py	95.45% <0.00%> (-4.55%)	:arrow_down:
src/cnaas_nms/api/firmware.py	22.48% <0.00%> (-1.20%)	:arrow_down:
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[indy-independence]

The code looks nice! I did a few tests in our lab setup and it seems to work with manually adding a second link between a core and a dist device. I also ran a zerotouch/init of one dist switch and that still seems to be working. I do think this branch has been forked from some old code though? Doesn't seem up to date with develop branch

[stveit]

Yeah i saw that it was behind a lot, i mistakenly branched off the wrong thing. I've rebased on develop now. do you mind if i force push it here, or should i make a new PR to avoid rebasing shared code?

[indy-independence]

Should be fine with a force push, I'm confident no one else from here did changes in this feature branch

[stveit]

And nice that it seems to work, I still havent tried using the lab here so im not entirely ready to be running tests, ill have to spend some time figuring it out

[indy-independence]

Work continued in PR #270 , closing this