catmap icon indicating copy to clipboard operation
catmap copied to clipboard

Published 20 hours ago • verified publisher icon SUNCAT-Center

Fix #HACK's

Open ajmedford opened this issue 10 years ago • 2 comments

Nasty "quick fixes" are tagged with #HACK. Ideally all these should be changed to something more beautiful.

ajmedford avatar Sep 14 '13 03:09 ajmedford

Line 40 of solvers/solver_base.py has this line:

##HACK - not sure why the hell cvgs=self._coverage doesnt work

I tried replacing "cvgs = ReactionModelWrapper.getattr(self,'_coverage')" with "cvgs=self._coverage" and the tutorials seemed to work okay, is there a more specific instance of the error?

montoyjh avatar Jun 30 '15 23:06 montoyjh

This is a really old one. I think I have cleaned up the ReactionModelWrapper to improve the getattr synchronization since then, which may have fixed the issue. If it doesn't break the tutorials then lets change it.

ajmedford avatar Jul 01 '15 14:07 ajmedford