sui-components icon indicating copy to clipboard operation
sui-components copied to clipboard

Published 20 hours ago • verified publisher icon SUI-Components

🎨 React Hook useCallback has an unnecessary dependency

Open andresin87 opened this issue 2 years ago • 2 comments

Acceptance Criteria

/components/hook/usePortal/demo/articles/ArticleCustom/useTooltip.js

useCallback has an unnecessary dependency: isOpened

Definition of done (DOD)

  • [ ] remove it

Additional info

No response

andresin87 avatar Oct 18 '22 10:10 andresin87

can I work on this?

tes-balo avatar Oct 18 '22 21:10 tes-balo

Yes

andresin87 avatar Oct 18 '22 21:10 andresin87

I have removed the dependency. However, I am having trouble pushing the changes to my fork. The pre-push is always failing.

Screenshot from 2022-10-22 18-48-31 Screenshot from 2022-10-22 18-48-27

tes-balo avatar Oct 22 '22 17:10 tes-balo

Npm run respawn

andresin87 avatar Oct 22 '22 17:10 andresin87

Npm run test

andresin87 avatar Oct 22 '22 17:10 andresin87