sui-components icon indicating copy to clipboard operation
sui-components copied to clipboard

✨AtomButton: the returned button children structure might never change

Open andresin87 opened this issue 2 years ago • 4 comments

Is your iteration request related to a problem?

No response

Describe the solution you'd like

The resulting html inner structure might be always the same

Screenshots

No response

Additional context**

No response

Additional info

No response

andresin87 avatar Sep 30 '22 07:09 andresin87

@andresin87 can you specify which AtomButton you are talking about?

Abhirv08 avatar Oct 01 '22 06:10 Abhirv08

components/atom/button/src/index.js

andresin87 avatar Oct 01 '22 19:10 andresin87

The not isLoading return ternary part has a conditionaly erapper depending on if the component has or not a left/right icon. The idea is to aleays wrap the children with this element, nos changing the dom structure

andresin87 avatar Oct 01 '22 20:10 andresin87

@andresin87 is this open ? Can I work on this

rparthas avatar Oct 26 '22 10:10 rparthas