sui-components icon indicating copy to clipboard operation
sui-components copied to clipboard

molecule/rating performance refactor

Open andresin87 opened this issue 4 years ago • 2 comments

Is your iteration request related to a problem? The pr 4 the molecule/rating #1380 adds lots of JS logic which looks like it can be obtained using CSS. (Highlight the component on hover or active)

Describe the solution you'd like I think we can get the same behavior if we combine the logic:

  • highlight all contained elements of the wrapper.
  • recover the following elements of the targeted contained element.

...for both purposes (active or hover).

Additional context

andresin87 avatar Jan 21 '21 12:01 andresin87

Just for inspiration here is an example from habitaclia that is similar to the proposed solution: https://www.habitaclia.com/i3496001239109

adriadoz avatar Jan 21 '21 12:01 adriadoz

Also there is a blinking problem. That's because star component uses margin instead of padding and cursor is not hovering the icon between that space.

ca01db13a0f03686470c3d2b0c7a336e

nistadev avatar Jul 26 '21 08:07 nistadev